Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PageUp and PageDown to keyMappings #677

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Add PageUp and PageDown to keyMappings #677

merged 1 commit into from
Apr 28, 2023

Conversation

seb-jean
Copy link
Contributor

@seb-jean seb-jean commented Apr 27, 2023

I added PageUp and PageDown to keyMappings

@seb-jean seb-jean changed the title Add PageUp and PageDown to keyMappings Add PageUp and PageDown to keyMappings Apr 27, 2023
@dhh dhh merged commit 66b4ac1 into hotwired:main Apr 28, 2023
@@ -24,6 +24,8 @@ export const defaultSchema: Schema = {
right: "ArrowRight",
home: "Home",
end: "End",
page_up: "PageUp",
page_left: "PageLeft",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be page_down: PageDown?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should. Could you PR? Thanks for catching!

Copy link
Contributor Author

@seb-jean seb-jean Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix by #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants