Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the Controller instance to registerActionOption callback #691

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Pass the Controller instance to registerActionOption callback #691

merged 1 commit into from
Jul 12, 2023

Conversation

lb-
Copy link
Contributor

@lb- lb- commented Jun 20, 2023

@lb- lb- changed the title Pass controller instance to registerActionOption callback Pass the Controller instance to registerActionOption callback Jun 20, 2023
@lb- lb- force-pushed the feature/668-register-action-option-callback-controller branch from ef65ce8 to 5817449 Compare June 21, 2023 07:58
@dhh dhh requested a review from marcoroth June 24, 2023 11:22
@lb-
Copy link
Contributor Author

lb- commented Jun 26, 2023

I'll try to rebase / resolve conflicts on this when I get the chance.

@lb-
Pass controller instance to registerActionOption callback
b3542a2 
- Add ability for registerActionOption callbacks to receive the controller instance
- Relates to hotwired#668
@lb- lb- force-pushed the feature/668-register-action-option-callback-controller branch from 5817449 to b3542a2 Compare June 26, 2023 21:49
@lb-
Copy link
Contributor Author

lb- commented Jun 26, 2023

Rebased

marcoroth
marcoroth approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good to me, thank you @lb-!

@marcoroth marcoroth merged commit da8be68 into hotwired:main Jul 12, 2023
@marcoroth marcoroth mentioned this pull request Jul 12, 2023
Closed
@lb- lb- deleted the feature/668-register-action-option-callback-controller branch July 12, 2023 20:47
@lb-
Copy link
Contributor Author

lb- commented Jul 12, 2023

Thanks @marcoroth

@lb- lb- mentioned this pull request Jul 17, 2023
Merged
3 tasks
@lb-
Copy link
Contributor Author

lb- commented Aug 29, 2023

This release has gone out but I don't think the docs have been updated.

https://stimulus.hotwired.dev/reference/actions#options

Screenshot_20230829-203905

@lb-
Copy link
Contributor Author

lb- commented Sep 13, 2023

The docs are now updated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lb- @marcoroth