Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the ActionEvent (with params) to registerActionOption callbacks #692

Merged

Conversation

lb-
Copy link
Contributor

@lb- lb- commented Jun 20, 2023

- Add ability for registerActionOption callbacks to receive the event after `params` have been resolved
- Relates to hotwired#668
@lb- lb- force-pushed the feature/668-action-option-callback-event-with-params branch from e1f111d to f78f032 Compare June 21, 2023 07:56
@dhh dhh requested a review from adrienpoly June 24, 2023 11:21
Copy link
Member

@adrienpoly adrienpoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @lb-

@dhh dhh merged commit 7bf453c into hotwired:main Jun 26, 2023
@lb- lb- deleted the feature/668-action-option-callback-event-with-params branch June 26, 2023 11:38
@lb-
Copy link
Contributor Author

lb- commented Jun 26, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants