Add support for number values with underscores #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lb-
force-pushed
the
feature/646-add-support-for-numeric-separators-numbers
branch
2 times, most recently
from
1643cea
to
a3ad946
Compare
- Aligns with JavaScript numeric separators - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#numeric_separators - Example `data-wait-delay-value="7_500"` - Closes hotwired#646
lb-
force-pushed
the
feature/646-add-support-for-numeric-separators-numbers
branch
from
a3ad946
to
b23474f
Compare
|
Thanks for merging dhh |
adammiribyan
reviewed
Sep 1, 2023
| @@ -131,7 +131,7 @@ The list of supported modifier keys is shown below. | |||
|
|
|||
| Sometimes a controller needs to listen for events dispatched on the global `window` or `document` objects. | |||
|
|
|||
| You can append `@window` or `@document` to the event name (along with any filter modifier) in an action descriptor to install the event listener on `window` or `document`, respectively, as in the following example: | |||
| You can append `@window` or `@document` to the event name (along with any filter modifer) in an action descriptor to install the event listener on `window` or `document`, respectively, as in the following example: | |||
There was a problem hiding this comment.
Yep. It was fixed though - see #704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data-wait-delay-value="7_000"