Initialize Bridge instances within the library
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lize the bridge with a WebView instance through Bridge.initialize(webView).
* main: Rename BridgeDestination functions so they're more clear and consistent Use a property to enable debug logging instead of a function Log an event if a message fails to send Use .getOrPut() to get or create new component instances # Conflicts: # strada/src/test/kotlin/dev/hotwire/strada/BridgeDelegateTest.kt
mbarta
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the library to take control of create/destroying
Bridgeinstances. ABridgehas a 1:1 relationship with aWebView, so whenever an app creates/uses a newWebViewinstances, it must call:Bridge.initialize(webView)From there, the library will create a new internal
Bridgeinstance if one doesn't already exist for theWebViewinstance. This change makes it much easier for apps usingturbo-android, since theWebViewinstance is swapped between destinations and maintaining a reference to the correspondingBridgeinstance is no longer an app concern.