Fix BridgeDelegate
lifecycle issues
#15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses three lifecycle bugs that were overlooked:
onStop()
was called, theonStop()
event was not passed to the destination's components, because thedestinationIsActive
flag was set tofalse
before attempting to pass along theonStop()
event to active componentsdestinationIsActive
flag defaulted totrue
instead of inspecting the destination's state directlybridgeDidReceiveMessage()
did not check to see if the destination was active before passing along the message to the corresponding component. This meant that if amessage
was received from the web after the view had been destroyed, it would lead to a crash in the component if it attempted to access its view.