Rename functions to better match behavior

hotwired · Dec 12, 2023 · 12c6661 · 12c6661
1 parent bf8049f
commit 12c6661
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/Source/Turbo Navigator/TurboNavigator.swift b/Source/Turbo Navigator/TurboNavigator.swift
@@ -107,7 +107,7 @@ extension TurboNavigator: SessionDelegate {
 
  public func sessionDidStartFormSubmission(_ session: Session) {
  if let url = session.topmostVisitable?.visitableURL {
- delegate.willSubmitForm(to: url)
+ delegate.formSubmissionDidStart(to: url)
  }
  }
 
@@ -116,7 +116,7 @@ extension TurboNavigator: SessionDelegate {
  self.session.clearSnapshotCache()
  }
  if let url = session.topmostVisitable?.visitableURL {
- delegate.didSubmitForm(at: url)
+ delegate.formSubmissionDidFinish(at: url)
  }
  }
 

diff --git a/Source/Turbo Navigator/TurboNavigatorDelegate.swift b/Source/Turbo Navigator/TurboNavigatorDelegate.swift
@@ -21,13 +21,13 @@ public protocol TurboNavigatorDelegate: AnyObject {
  /// If not implemented, default handling will be performed.
  func didReceiveAuthenticationChallenge(_ challenge: URLAuthenticationChallenge, completionHandler: @escaping (URLSession.AuthChallengeDisposition, URLCredential?) -> Void)
 
- /// Optional. Called before a form is submitted.
+ /// Optional. Called after a form starts a submission.
  /// If not implemented, no action is taken.
- func willSubmitForm(to url: URL)
+ func formSubmissionDidStart(to url: URL)
 
- /// Optional. Called when a form is submitted.
+ /// Optional. Called after a form finishes a submission.
  /// If not implemented, no action is taken.
- func didSubmitForm(at url: URL)
+ func formSubmissionDidFinish(at url: URL)
 }
 
 public extension TurboNavigatorDelegate {
@@ -45,7 +45,7 @@ public extension TurboNavigatorDelegate {
  completionHandler(.performDefaultHandling, nil)
  }
 
- func willSubmitForm(to url: URL) {}
+ func formSubmissionDidStart(to url: URL) {}
 
- func didSubmitForm(at url: URL) {}
+ func formSubmissionDidFinish(at url: URL) {}
 }