Fix refresh behavior #220
Merged
Fix refresh behavior #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivaresf
commented
Jul 4, 2024
| } | ||
|
|
||
| private func refreshIfTopViewControllerIsVisitable(from stack: NavigationStackType) { | ||
| if let navControllerTopmostVisitable = navController(for: stack).topViewController as? Visitable { |
There was a problem hiding this comment.
We should discuss the best way to pass this refresh message to a non-Visitable view controller.
There was a problem hiding this comment.
As you mentioned on the call, leveraging the PathConfigurationIdentifiable protocol is an option here.
olivaresf
commented
Jul 4, 2024
| switch navigationStack { | ||
| case .main: session.reload() |
There was a problem hiding this comment.
We can't use session.reload() because topmostVisitable does not change when a view controller is popped (or dismissed) programmatically. For example:
- Propose visit to URL "/one"
- Visit completes, session.topmostVisitable = "one"
- Propose visit to URL "/two"
- Visit completes, session.topmostVisitable = "two"
- Propose visit to URL "/refresh_historical_location" with presentation: refresh
- Visitable with visitableURL = "/two" is popped.
- session.reload() is called, which reloads the topmost visitable ("/two" set during step 4).
olivaresf
force-pushed
the
fix-refresh
branch
3 times, most recently
from
cfa9487 to
23d5ca9
Compare
svara
approved these changes
Jul 11, 2024
| } | ||
|
|
||
| private func refreshIfTopViewControllerIsVisitable(from stack: NavigationStackType) { | ||
| if let navControllerTopmostVisitable = navController(for: stack).topViewController as? Visitable { |
There was a problem hiding this comment.
As you mentioned on the call, leveraging the PathConfigurationIdentifiable protocol is an option here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing, I found that when a visit with a refresh presentation is proposed,
TurboNavigatorHierarchyControllerwill correctly pop (or dismiss) and then ask the session to reload. However, the session does not know that the topmost visitable changed, so a reload will end up reloading the last successfully loaded visit – the visitable that was just popped (or dismissed).