Require AttributeAccessorsPerThread #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes library loading error in edge Rails
afcapel
reviewed
Nov 23, 2023
|
Thanks @sevos! |
|
@afcapel Are we sure this got merged? |
|
Oh, sorry, I didn't notice the PR was not against main. #523 is merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes library loading error in edge Rails.
Repository reproducing the problem: https://github.com/sevos/example_rails_turbo_morph
I've tested the library with Rails 7.2 (main branch), and the library failed to load with the undefined method
thread_mattr_accessoronTurbo:Moduleerror. Locally, I fixed it by requiring the appropriate file from ActiveSupport before loading Gemfile in application.rb. This PR should fix this.