Only include Turbo::Broadcastable::TestHelper with Action Cable

[seanpdoyle]

Closes #573
Related to #565

Re-structure the automatic inclusion of the
Turbo::Broadcastable::TestHelper module so that it's only automatically loaded and installed when Action Cable is available to the runtime.

[afcapel]

@seanpdoyle what do you think about adding a ActiveSupport.on_load(:action_cable) block here? The Rails guides suggest this technique to execute code that depends on several dependencies.

[seanpdoyle]

I like that idea. I was unsure about nesting, but I'll try it out.

[t27duck]

Cautiously optimistic, but this branch seems to fix the test suite for my personal app.

[afcapel]

Thanks @seanpdoyle 🙏

[joshuay03]

@seanpdoyle Is this planned to be released / back-ported anytime soon?

[nflorentin]

@seanpdoyle

Upgrading from 2.0.0 to 2.0.2 breaks with the following error :

uninitialized constant Turbo::Broadcastable::TestHelper::ActionCable (NameError)

          include ActionCable::TestHelper

I use turbo-rails without ActionCable, I don't need broadcasting.

I don't understand why Turbo::Broadcastable::TestHelper is included by default, it seems to make turbo-rails not usable without action cable.

Is there an option to override that behaviour ?

Thanks in advance :-)

[seanpdoyle]

@nflorentin this change is not included in 2.0.2. Does depending on main resolve the issue?

[nflorentin]

@seanpdoyle ops ! yes, I'm sorry, I misunderstood the change and though it was in 2.0.2.

It does resolve the issue. Will wait for 2.0.3.

Thanks for your hard work !

[aaronjensen]

Asking a question here with the best intentions given that this change fixes a breaking change that prevents people from updating to 2.X.

Is there a significant impediment in the release process that prevents an immediate release after a fix like this is merged in order to unblock people that are downstream?

If so, is there any way that I could help alleviate it? In a few of the Rails-adjacent projects (propshaft, turbo, turbo-rails) I've noticed that things get merged (which is great) but then releases don't happen for sometimes weeks or months.

I know everyone is busy doing their full-time job so I'm not asking for heroics, I'm genuinely curious if there's anything I can do to help alleviate the cost of a release? Thank you!

[seanpdoyle]

@afcapel @jorgemanrubia could either of you consider a fast-tracked 2.0.3 release?

[afcapel]

I've just published 2.0.3 👍

[aaronjensen]

Thank you!