Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI matrix for Rails 8 #706

Closed
wants to merge 7 commits into from
+8 −11
Closed

update CI matrix for Rails 8 #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2ba80b
update CI matrix
adrienpoly Dec 23, 2024
b365fd8
exclude ruby 3.2 rails 8.0
adrienpoly Dec 23, 2024
0aa6e33
update sqlite3
adrienpoly Dec 23, 2024
a3a8978
set ruby minimum version to 3.1
adrienpoly Dec 23, 2024
9b58de5
update bug_report_template
adrienpoly Dec 23, 2024
ad6cfd6
exclude ruby 3.1 rails 8.0
adrienpoly Dec 23, 2024
fd777ca
remove rails 7.0
adrienpoly Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,14 @@ jobs:
strategy:
fail-fast: false
matrix:
rails: [ "6.1", "7.0", "7.1", "7.2" ]
ruby: [ "2.7", "3.0", "3.1", "3.2", "3.3" ]
rails: [ "7.1", "7.2", "8.0" ]
ruby: [ "3.1", "3.2", "3.3" ]
allow-fail: [ false ]
include:
- { ruby: "2.6", rails: "6.1" }
- { ruby: "3.3", rails: "main", allow-fail: true }
- { ruby: "3.2", rails: "main", allow-fail: true }
- { ruby: "head", rails: "main", allow-fail: true }
exclude:
- { ruby: "2.7", rails: "7.2" }
- { ruby: "3.0", rails: "7.2" }
- { ruby: "3.1", rails: "8.0" }

env:
FERRUM_PROCESS_TIMEOUT: 25
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ group :test do
gem 'capybara'
gem 'rexml'
gem 'cuprite', '~> 0.9', require: 'capybara/cuprite'
gem 'sqlite3', '1.5'
gem 'sqlite3'
end
2 changes: 1 addition & 1 deletion bug_report_template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
gem "rails"
gem "propshaft"
gem "puma"
gem "sqlite3", "~> 1.4"
gem "sqlite3"
gem "turbo-rails"

gem "capybara"
Expand Down
6 changes: 3 additions & 3 deletions turbo-rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ Gem::Specification.new do |s|
s.homepage = "https://github.com/hotwired/turbo-rails"
s.license = "MIT"

s.required_ruby_version = ">= 2.6.0"
s.required_ruby_version = ">= 3.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR.

There is a fair amount of overlap with #698, which also changes the Ruby version requirement.

As it relates to #681, I think there still needs to be a final release that deprecates support for 2.6 before main can drop support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes thanks for pointing it out, I didn't see that PR. #698 looks more complete indeed. I think I ll close this one. the only addon is Rails 8 but that can easily be backported to #698


s.add_dependency "actionpack", ">= 6.0.0"
s.add_dependency "railties", ">= 6.0.0"
s.add_dependency "actionpack", ">= 7.0.0"
s.add_dependency "railties", ">= 7.0.0"

s.files = Dir["{app,config,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]

Expand Down
Loading