-
Notifications
You must be signed in to change notification settings - Fork 434
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test coverage for turbo-frame[disabled]
Support for the `[disabled]` attribute pre-dates this commit, but is largely untested. Prior to [hotwired/turbo-site#32][] and [hotwired/turbo-site#36][], there were no mentions of the attribute in the Turbo [Handbook][] or [Reference][] documentation. This commit adds functional test-level coverage for the existing behavior. When an `<a>` or `<form>` element targets a `<turbo-frame disabled>` element, Turbo skips intercepting and intervening, and instead navigates the page. Testing --- In addition, to avoid conflating `[data-turbo="false"]` and `<turbo-frame disabled>`, this commit also renames test and test fixture mentions of "disabled" to more accurately reflect which manner of skipping behavior is being tested. [Handbook]: https://github.com/hotwired/turbo-site/blob/52d5e7f1dfc26ac7a6e01c6a715857ccf5ed5081/docs/handbook/03_frames.md [Reference]: https://github.com/hotwired/turbo-site/blob/52d5e7f1dfc26ac7a6e01c6a715857ccf5ed5081/docs/reference/frames.md [hotwired/turbo-site#32]: hotwired/turbo-site#32 [hotwired/turbo-site#36]: hotwired/turbo-site#36
- Loading branch information
1 parent
178c817
commit d4e9d4c
Showing
4 changed files
with
28 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters