Hide Progress bar on turbo:load
#1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
issue-962
branch
5 times, most recently
from
3791846 to
96515ff
Compare
Closes [hotwired#962][] Prior to this commit, the progress bar is hidden between the Turbo Drive visits' `turbo:before-fetch-response` event and the `turbo:render` event. This commit changes that behavior to hide the bar when the Visit is complete (some time prior to the `turbo:load` event). [hotwired#962]: hotwired#962
seanpdoyle
force-pushed
the
issue-962
branch
from
96515ff to
f670354
Compare
|
Thanks Sean! |
domchristie
pushed a commit
to domchristie/turbo
that referenced
this pull request
Jul 20, 2024
Closes [hotwired#962][] Prior to this commit, the progress bar is hidden between the Turbo Drive visits' `turbo:before-fetch-response` event and the `turbo:render` event. This commit changes that behavior to hide the bar when the Visit is complete (some time prior to the `turbo:load` event). [hotwired#962]: hotwired#962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #962
Prior to this commit, the progress bar is hidden between the Turbo Drive visits'
turbo:before-fetch-responseevent and theturbo:renderevent.This commit changes that behavior to hide the bar when the Visit is complete (some time prior to the
turbo:loadevent).