Allow morphing between different URLs #1179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows morphing between similar types of pages that have different URLs. A proof of concept fix for the problem descrubed here: hotwired#1177 For example, if you set this meta tag: <meta name="turbo-morph-url-prefix" content="/images/"> Then morphing will be triggered for: - `/images/1` - `/images/12` - `/images/123` This solution has some downsides (e.g, won't work with nested resources). A regex-based alternative could address that. Please let me know if you'd be willing to consider this change and I'll go ahead and add tests.
|
A more elegant (and flexible) alternative to the above would be a per-link setting:
But I haven't explored this path yet... |
|
Closing this, I'll move the discussion to #1145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows morphing between similar types of pages that have different URLs.
A proof-of-concept-fix for the problem described here: #1177
For example, if you set this meta tag:
<meta name="turbo-morph-url-prefix" content="/images/">Then morphing will be triggered for:
/images/1/images/12/images/123BEFORE:
AFTER:
This solution has some downsides (e.g, won't work with nested resources). A regex-based alternative could address that.
Please let me know if you'd be willing to consider this change and I'll go ahead and add tests.