Read the csp meta tag nonce attribute and fall back to content #1254
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribute This PR allows Turbo to support rails/rails#51729 to allow using the `nonce` attribute as well as the `content` attribute. As described in rails/rails#51580 (comment) this makes it harder to extract the nonce value. Removed getMetaElement from public API as well.
codergeek121
force-pushed
the
use-nonce-and-content-attribute-for-csp
branch
from
f2b0e4c
to
f0aaca3
Compare
jorgemanrubia
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks @codergeek121.
We'll release a new version including this one shortly.
|
Great, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Turbo to support rails/rails#51729. This changes Turbo to read the meta tag's
nonceattribute first and fall back to thecontentattribute.As described in rails/rails#51580 (comment) this makes it harder to extract the nonce value.