Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frame reloading from links/forms nested inside a turbo-frame #370

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Fix frame reloading from links/forms nested inside a turbo-frame #370

merged 4 commits into from
Sep 7, 2021

Conversation

tleish
Copy link
Contributor

@tleish tleish commented Sep 2, 2021 •
edited
Loading

Closes #365

@tleish tleish mentioned this pull request Sep 2, 2021
Closed
@WriterZephos
Copy link

I am not a JavaScript expert but looking at #360 it seems like it was supposed to already test for this. Is there an existing test producing a false positive?

@tleish tleish changed the title create failing test for #365 Fix frame reloading from links instead a frame or a from a form Sep 3, 2021
@tleish
Copy link
Contributor Author

tleish commented Sep 3, 2021

FYI: The failed chrome test passed on firefox in the same build. Also in my local environment the failed test passes.

@tleish
Copy link
Contributor Author

tleish commented Sep 7, 2021

I am not a JavaScript expert but looking at #360 it seems like it was supposed to already test for this. Is there an existing test producing a false positive?

#360 fixed the case where the link existed outside a frame, but Turbo uses different code when the link exists inside a frame.

@kirillplatonov
Copy link
Contributor

@tleish could you please rebase from main? This should help with failing tests.

kirillplatonov
kirillplatonov reviewed Sep 7, 2021
View reviewed changes
src/tests/functional/frame_tests.ts Outdated
Comment on lines 203 to 204


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased and removed extra line

@tleish tleish changed the title Fix frame reloading from links instead a frame or a from a form Fix frame reloading from links/forms nested inside a turbo-frame Sep 7, 2021
@dhh dhh merged commit 23711c8 into hotwired:main Sep 7, 2021
dhh added a commit to seanpdoyle/turbo that referenced this pull request Sep 10, 2021
@dhh
Merge branch 'main' into pr/381
48a5b7c 
* main:
  Fix frame reloading from links/forms nested inside a turbo-frame (hotwired#370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillplatonov kirillplatonov kirillplatonov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frame not updating a second time unless I manually clear src attribute
4 participants
@tleish @WriterZephos @kirillplatonov @dhh