feat(formatters): support kulala-fmt #480
Conversation
| @@ -6,6 +6,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). | |||
|
|
|||
| #### [Unreleased](https://github.com/hougesen/mdsf/compare/v0.2.6...HEAD) | |||
|
|
|||
| - feat(formatters): support superhtml [`#479`](https://github.com/hougesen/mdsf/pull/479) | |||
There was a problem hiding this comment.
Why does the changelog of PR 480, contains the entry that could be in the 479 one?
And it's the same in 479, talking about things added in 478?
Is it because you don't have the PR id when you commit (obviously),but it voildbe updated with amend+ force merge once the PR is opened.
I'm asking because the history of the changelog is strange if you use git blame
There was a problem hiding this comment.
Yes, the changelog generator (https://github.com/CookPete/auto-changelog) uses commit data which means it is one commit behind.
For now it is just a part of my precommit command, but yes, it would be a lot clearer to append instead.
| @@ -279,6 +279,7 @@ mdsf init | |||
| | kdlfmt | [https://github.com/hougesen/kdlfmt](https://github.com/hougesen/kdlfmt) | | |||
| | ktfmt | [https://github.com/facebook/ktfmt](https://github.com/facebook/ktfmt) | | |||
| | ktlint | [https://github.com/pinterest/ktlint](https://github.com/pinterest/ktlint) | | |||
| | kulala-fmt | [https://github.com/mistweaverco/kulala-fmt](https://github.com/mistweaverco/kulala-fmt) | | |||
There was a problem hiding this comment.
I think I already raised the point, but I'm unsure in which issue, so please pardon me.
But having the list of linter without information about what they support looks strange to me.
I mean there is no way to know the .http format can be handled by kulala-fmt or that your tool supports HTTP format.
I see nothing in the code, or the test to know http fenced block could use kulala
Am I missing something?
There was a problem hiding this comment.
Please also consider
Closes #157