Add fallback-encoding per-repo option for non-utf8 text files #388
+164
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salemhilal
reviewed
Mar 17, 2021
jacobrose
reviewed
Mar 17, 2021
index/index.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| matchLimit = 5000 | ||
| manifestFilename = "metadata.gob" | ||
| excludedFileJsonFilename = "excluded_files.json" | ||
| filePeekSize = 2048 | ||
| filePeekSize = 1 << 20 |
There was a problem hiding this comment.
Hello! Why this big jump in filePeekSize?
There was a problem hiding this comment.
That pesky comment that contains á that breaks UTF-8 detection may be at the end of the file.
This is not a full solution, just a bet that source files should be less than a megabyte long.
A full solution could be retrying the whole indexing on decoding error.
But that felt more involved - though I could try it if you confirm that'd be better.
|
Hey! We're meeting now and generally like this PR. We have two asks before we merge it:
Thank you again! |
The big peek buf was needed to ensure that a non-utf8 rune at the end of the file does get the attention and be tried with the fallback encoding. A more robust approach is to just try the reading as-is, validating the encoding, and try the fallback encoding if this fails. Also add a test case.
|
Sorry for my slow reply, but now I've added a test case, and implemented the more robust retrying logic. |
|
May I assist reviewing this PR? |
pru-mike
pushed a commit
to pru-mike/hound
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to specify an alternate charset (fallback-encoding) per repository.