Add hyperlinks to repository root #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrarmstro
commented
Apr 14, 2021
jrarmstro
commented
- Add a link to the base repository URL when clicking on the repository name
- Pull URL parsing logic in to its own method
- Update tests accordingly
- Update bindata
|
Hey, thanks for being patient with us! This looks really good. If you fix the merge conflicts with |
salemhilal
approved these changes
Jul 2, 2021
|
Thank you! |
AlexFielder
added a commit
to AlexFielder/hound
that referenced
this pull request
Jul 28, 2021
* Update config-example.json * Add CONTRIBUTING.md file * Dockerfile should use github.com/hound-search This fixing the docker build issue. * make listen URL clickable in iTerm (hound-search#340) * Add Jest tests and Prettier support (hound-search#343) This commit adds support for Jest and writes a few simple tests as proof. Adding a test is as easy as adding a file that ends in `.test.js` next to the file you want to test. Any file that matches that pattern should have access to Jest functions. The whole test suite can be run with `npm run test`. I also added support for Prettier. Running `npm run format` should run Prettier on any staged changes. I thought about adding Husky to automatically run Prettier as a pre-commit hook, but it seems as though Husky requires git v2.13 which would require me upgrading Git. I didn't add support for ESLint yet since I figured that may be a slightly more involved conversation — Prettier seems to be generally uncontroverical and is generally only slightly configurable, whereas ESlint is highly configurable and behaves however we want it to. * Git VCS driver: Support non-default target refs (hound-search#345) Currently, only the default ref (`master`) is supported. - Allow target non-default target refs to be specified via configs. - Add config-driven target ref auto-detection using the `HEAD` branch. - Update default repo base URL pattern to link to the content revision, accounting for potential non-default target ref usage. - Add global-level VCS configs which are merged into the repo-level configs during startup (repo-level vals take precedence). * Exclude file path (hound-search#347) * index: add a search option to exclude files given a regexp * api: add the excludeFiles query parameter Set the index search options ExcludeFileRegexp with this parameter to allow excluding files from the search via a regexp. * js: add the excludeFiles search parameter * css: increase the label width to fit 'Exclude file path' * js: correctly check that advanced is empty * Update README with contact info for maintainers. (hound-search#348) I don't think there's a clear way to see who has push privs to this repo from the public, and even if there is, the "Get In Touch" section should probably list the maintainers. * incorporate detailing around gopath in README's quick start instructions (hound-search#352) Co-authored-by: Rebecca Lau <blobbered@users.noreply.github.com> * pin alpine version to make the docker pass * Update Dockerfile * More detailed setup documents with less assumptions on users (hound-search#359) This commit updates the readme to be a little more verbose for people who don't necessarily have Go or Docker set up, but who want to contribute nonetheless. * Apply the old patch * add some figures * remove the idea code * get it untitled * remove * add .idea dev tools * remove simple config * get config back * detailing tests and simplifying the setup * Commit TLS support guide Co-authored-by: Salem <salemhilal@gmail.com> * make the statement terser * delete unused img * rewording * back to the old path * Update README.md * Update README.md * Update README.md * Update README.md Co-authored-by: Salem <salemhilal@gmail.com> * Initialize Go Modules `go mod init github.com/hound-search/hound` * Replace jteeuwen/go-bindata with go-bindata/go-bindata The former package is unmainatained since a while and the replacement also fixes this bug I encountered when trying to build the package: jteeuwen/discussions#6 * update Go version requirement in README file * Add a -version flag to Houndd (hound-search#362) This commit adds a `-version` flag to houndd. Running `houndd -version` prints the current version and exits. Co-authored-by: Kartikay Shandil <kartikays@sahaj.ai> * Add padding between advanced mode text inputs * add margin bottom to fields that are not last * update front end bundles Co-authored-by: Blobb Ered <@blobbered> * Setup Github Actions CI (hound-search#354) * Setup Github Actions CI Replaces Travis CI with Github Actions for better integration. Jobs are run against more recent Go versions, namely 1.12 to 1.14 . . For further documentation see - https://github.com/actions/setup-go - and https://help.github.com/en/actions This adds `-race` flag to the Go tests and will run a meta linter (golangci-lint). * keep travis in until github workflows is tested * tidy go mods * remove lint command from github workflow * add back go-bindata to go modules list * up version of actions checkout to fix deprecation errors * return go bindata to the go.sum file as well Co-authored-by: Andreas Linz <anli@spreadshirt.net> * Add a github actions badge Thanks again @klingtnet and @blobbered for making this possible! * Update README.md (hound-search#369) Add clarification of using file:// protocol for accessing locally pulled repos * Added new folder docs with config-options description on options. (hound-search#370) * Added new folder docs with config-options description on options. * Peer review comment update updated formatting for config options documentation and added link in readme. * readme link update * link update * Minor edits from code review Co-authored-by: kayyapil <k.ayyapillai@reply.com> Co-authored-by: ehrktia <a.karthie+github@pm.me> Co-authored-by: Salem <salemhilal@gmail.com> * Test windows * Run Go build and test on Ubuntu Linux and Windows * Add lint * Install dependencies in Dockerfile * Fix typo * Adding a tip for windows users (hound-search#379) * Adding a tip for windows users * Update README.md Co-authored-by: Salem <salemhilal@gmail.com> Co-authored-by: Salem <salemhilal@gmail.com> * Use tini as default entry point (hound-search#376) * Add a warning for the default branch rename (hound-search#380) * Add a warning for the default branch rename * Add a link to Github's renaming documentation. * Update README to reflect branch rename. (hound-search#384) * Update version in main.go * support github webhook * Omit ports in constructed URL (hound-search#383) * Improve accessibility (hound-search#398) * Resolve WCAG2AA.Principle3.Guideline3_1.3_1_1.H57.2 * Resolve WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.InputText.Name * Resolve WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.Button.Name * Improve stats contrast * Improve advanced text contrast * Improve repo title contrast * Improve contrast in advanced section * Improve line number contrast * Improve excluded files contrast * Improve "load all" button contrast * Automatically build docker image and publish to ghcr.io (hound-search#401) * Feat: Use goreleaser * Feat: Add docker build, remove goreleaser * Fix: Add image name * Feat: Use ghcr.io and build-push-action@2 * We try again * Trying yet again * Fix: Use actor and GITHUB_TOKEN * Fix: Use github.actor in image tag path * Fix: use github.repository_owner instead of github.actor When you have an organisation, github.actor != github.repository_owner Co-authored-by: Jone Marius Vignes <jvig@ihelse.net> * Update default-config.json (hound-search#391) * Update default-config.json * Update default-config.json (ref: main) * Add hyperlinks to repository root (hound-search#396) * Add literal search option (hound-search#397) * Add literal search option * Pull EscapeRegExp into common.js * Add db/ to Jest ignore patterns * Test EscapeRegExp() matches its input * Test vacuous EscapeRegExp * Give repo links a target of blank (hound-search#404) Add rel="noopener noreferrer" to _blank links Co-authored-by: Joseph Price <pricejosephd@gmail.com> Co-authored-by: dschott <dschott@etsy.com> Co-authored-by: Nicolas R <cpan@atoomic.org> Co-authored-by: Igor <igorwwwwwwwwwwwwwwwwwwww@users.noreply.github.com> Co-authored-by: Salem <salemhilal@gmail.com> Co-authored-by: Richard Liang <rwliang@users.noreply.github.com> Co-authored-by: Vincent Rischmann <vincent@rischmann.fr> Co-authored-by: Blobb Ered <5307533+blobbered@users.noreply.github.com> Co-authored-by: Rebecca Lau <blobbered@users.noreply.github.com> Co-authored-by: Ruixi Fan <rfan@etsy.com> Co-authored-by: Ruixi Fan <69488297+rfan-debug@users.noreply.github.com> Co-authored-by: Andreas Linz <anli@spreadshirt.net> Co-authored-by: Rebecca Lau <rblau@etsy.com> Co-authored-by: Kartikay Shandil <shandilkartikay@gmail.com> Co-authored-by: Kartikay Shandil <kartikays@sahaj.ai> Co-authored-by: Ashley Roach <aroach@gmail.com> Co-authored-by: karthick <a.karthie+github@gmail.com> Co-authored-by: kayyapil <k.ayyapillai@reply.com> Co-authored-by: ehrktia <a.karthie+github@pm.me> Co-authored-by: David Kolossa <david.kolossa@posteo.de> Co-authored-by: Sandro <sandro.jaeckel@gmail.com> Co-authored-by: Andrew Stanton <StingyJack@users.noreply.github.com> Co-authored-by: David Schott <dschott68@users.noreply.github.com> Co-authored-by: Cor Bosman <cor@xs4all.net> Co-authored-by: Jacob Rose <jacob@usroses.org> Co-authored-by: Alexander Chiu <alexanderchiu@users.noreply.github.com> Co-authored-by: Joel Armstrong <mrjoelarmstrong@gmail.com> Co-authored-by: Jone Marius Vignes <73816+inful@users.noreply.github.com> Co-authored-by: Jone Marius Vignes <jvig@ihelse.net> Co-authored-by: Simon Legner <Simon.Legner@gmail.com> Co-authored-by: Bucky Schwarz <hoorayimhelping@users.noreply.github.com>
rwtnorton
added a commit
to EasyPost/hound
that referenced
this pull request
Dec 2, 2024
Summary: Merge pull request hound-search#387 from corbosman/main Adds support for Github webhooks, so that committing to a repository sends a webhook request to hound, which then re-indexes the repository. Per contributor @corbosman, this enabled his org to use Hound with thousands of repos and keep indexes fresh. Omit ports in constructed URL (hound-search#383) Improve accessibility (hound-search#398) * Resolve WCAG2AA.Principle3.Guideline3_1.3_1_1.H57.2 * Resolve WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.InputText.Name * Resolve WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.Button.Name * Improve stats contrast * Improve advanced text contrast * Improve repo title contrast * Improve contrast in advanced section * Improve line number contrast * Improve excluded files contrast * Improve "load all" button contrast Automatically build docker image and publish to ghcr.io (hound-search#401) * Feat: Use goreleaser * Feat: Add docker build, remove goreleaser * Fix: Add image name * Feat: Use ghcr.io and build-push-action@2 * We try again * Trying yet again * Fix: Use actor and GITHUB_TOKEN * Fix: Use github.actor in image tag path * Fix: use github.repository_owner instead of github.actor When you have an organisation, github.actor != github.repository_owner Co-authored-by: Jone Marius Vignes <jvig@ihelse.net> Update default-config.json (hound-search#391) * Update default-config.json * Update default-config.json (ref: main) Add hyperlinks to repository root (hound-search#396) Add literal search option (hound-search#397) * Add literal search option * Pull EscapeRegExp into common.js * Add db/ to Jest ignore patterns * Test EscapeRegExp() matches its input * Test vacuous EscapeRegExp Give repo links a target of blank (hound-search#404) Add rel="noopener noreferrer" to _blank links Adding pull request template Update README to use ghcr.io Currently, the README suggests running an outdated version of hound. There's been a lot of good work done in the past [3 years](https://hub.docker.com/r/etsy/hound/tags). The container registry was updated in hound-search#401 Add latest tag Fix typo Remove default branch warning It's been almost a year since we renamed the default branch to `main`. The warning can probably be taken out. ui: collapse and expand files Fixes hound-search#182 Fix the linter, update golang versions. (hound-search#422) * golangci to v3 per https://stackoverflow.com/questions/71758856/github-action-for-golangci-lint-fails-with-cant-load-fmt * add with latest * add setup-go and specific version * update version * Use only one actions/checkout, previous version of go linter The linter (`golangci`) and the action that runs the linter (`golangci/golangci-lint-action`) are separate. The linter seems to be running but finding new errors, so this change might be enough to temporarily squash those. * Drop go 1.12 and 1.13, add 1.17 and 1.18 There's a new golang version every 6 months. The latest two golang versions are supported officially. I'm keeping 1.14 around for now since it was previously the latest supported version. * Only run linter on 1.17 The 1.18 linter has import issues that we'll investigate later. * update version * nolint * nolint * nolint * nolint * update lint to go 1.18 Co-authored-by: David Schott <dschott@etsy.com> chore: Bump version const Otherwise, `houndd -version` spits out the wrong version. Anticipating the patch release that this commit will go out with. Add config.json to .gitignore Add .dockerignore Adding the setup-qemu-action to enable multiplatform docker builds from github actions Attempt auto-generated files Add badge refactor to use filenames and no regex add config override add some docs add config test Update version for release Update Makefile to reflect the move to a go module. Convert Signal to es6 class. (hound-search#440) Upgrade all devDependencies in webpack build. (hound-search#439) Corrected a typo in readme.md chore: add manual install option (hound-search#446) * chore: add another option to install hound * chore: format * chore: add $GOPATH/bin in installation * fix indentation for bulleted list --------- Co-authored-by: dschott <dschott@etsy.com> kick off for pull requests (hound-search#448) Add my name to the README change Advanced options div ID Merge pull request hound-search#449 from hound-search/jswensen-bug-385 [Issue 385] change Advanced options div ID Update list of maintainers with additional volunteers (hound-search#451) Add `display-name` option to customize/disambiguate output (hound-search#454) Rebuild ui/bindata.go It seems that ui/bindata.go has got out of sync; the changes from d25b221 aren't applying and the advanced dialog box is always showing, as the div doesn't match. Regenerating this seems to make things work Closes: hound-search#453 bump the version (hound-search#457) Update alpine to 3.16 and switch from bzr to breezy (hound-search#429) Co-authored-by: David Schott <dschott68@users.noreply.github.com> Add support for manually setting a limit on results * Added a query parameter to allow user to specify max results, rather than a hard limit at 5000, for each index. * Added support for a default max result limit in the config. If unset, it remains at the former default of 5000 results per index. * Fixed issue where no results would be returned if the limit was exceeded - now it simply returns the results up to the limit. Add tests for parse min/max bounds Merge pull request hound-search#464 from hound-search/AlexTalks/tests Add support for manually setting a limit on results(copy) Another attempt to replace go-bindata with //go:embed (hound-search#460) * switch from go-bindata to embed Signed-off-by: moson-mo <mo-son@mailbox.org> * bump semver dependency to v4 Signed-off-by: moson-mo <mo-son@mailbox.org> * amend workflow jobs for go-embed switch Signed-off-by: moson-mo <mo-son@mailbox.org> --------- Signed-off-by: moson-mo <mo-son@mailbox.org> Remove jquery from hound Merge pull request hound-search#465 from hound-search/iagu/remove-jquery Remove jquery from hound Add fake source Copy with rsync fake: Do not copy, use a symlink Rebase on the latest version Replace tar hashing with golang.org/x/mod and add options Rename vcs driver from "fake" to "local" Rename "detect-changes" to "watch-changes" Update the README Clarify a few things in the comments Suppress the linting error Prevent line numbers from being copied in search results Merge remote-tracking branch 'mainline/main' into sync_with_mainline support phab repo links Reviewers: #risk_assessment_framework! Subscribers: #risk_assessment_framework Differential Revision: https://phab.easypo.net/D61327
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.