Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild ui/bindata.go #456

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Rebuild ui/bindata.go #456

merged 1 commit into from
Apr 21, 2023

Conversation

ianw
Copy link
Contributor

@ianw ianw commented Apr 21, 2023

It seems that ui/bindata.go has got out of sync; the changes from d25b221 aren't applying and the advanced dialog box is always showing, as the div doesn't match.

Regenerating this seems to make things work

Closes: #453

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The PR fulfills these requirements:

  • All tests are passing?
  • New/updated tests are included?
  • If any static assets have been updated, has ui/bindata.go been regenerated?
  • Are there doc blocks for functions that I updated/created?

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

It seems that ui/bindata.go has got out of sync; the changes from
d25b221 aren't applying and the
advanced dialog box is always showing, as the div doesn't match.

Regenerating this seems to make things work

Closes: hound-search#453
@salemhilal
Copy link
Contributor

Thank you! We really need an automated check for this step.

@salemhilal salemhilal merged commit 3cef379 into hound-search:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issue
2 participants