Fix several tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
commented
Sep 25, 2021
| .and_then(|filter_array| { | ||
| let is_not_null = is_not_null(filter_array as &dyn Array); | ||
| let and_filter = and(&is_not_null, filter_array)?; | ||
| filter_record_batch(batch, &and_filter) |
There was a problem hiding this comment.
per filter_record_batch doc, we should make filter array null free first:
/// Returns a new [RecordBatch] with arrays containing only values matching the filter.
/// WARNING: the nulls of `filter` are ignored and the value on its slot is considered.
/// Therefore, it is considered undefined behavior to pass `filter` with null values.
pub fn filter_record_batch(
record_batch: &RecordBatch,
filter_values: &BooleanArray,
) -> Result<RecordBatch> {| @@ -944,7 +944,7 @@ async fn csv_query_nullif_divide_by_0() -> Result<()> { | |||
| let expected = vec![ | |||
| vec!["258"], | |||
| vec!["664"], | |||
| vec!["NULL"], | |||
There was a problem hiding this comment.
I've changed part of the expected Null value representation in this file, from "NULL" to "" to make NULL representation consistent in the file itself. (some of NULL are represented as "NULL" and others are empty string already). and follow that in arrow2 at the same time.
| ); | ||
| // TODO: precision here. |
There was a problem hiding this comment.
I haven't dig too much into the interval calculation method here. fail due to precision problem I think
houqp
pushed a commit
that referenced
this pull request
May 27, 2024
…he#10527) * chore: merge main and resolve conflict * chore: use less copy * chore: remove clone * remove more clones (#8) * refactor: use HashSet<&Expr> instead of HashSet<String> * refactor: remove more cloning * chore: reduce string allocation Co-authored-by: Adam Curtis <adam.curtis.dev@gmail.com> * chore: return internal error instead of panacing * chore: use arg display_name as hash key instead of a hashed value --------- Co-authored-by: Adam Curtis <adam.curtis.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.