Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--tidyall-class doesn't work #43

Open
2shortplanks opened this issue Sep 22, 2015 · 2 comments
Open

--tidyall-class doesn't work #43

2shortplanks opened this issue Sep 22, 2015 · 2 comments

Comments

@2shortplanks
Copy link
Contributor

During the change to Moo the code to load a new tidyall subclass was moved inside the new_from_conf_file method in Code::TidyAll. However, that method is now called on the passed tidyall class in the tidyall script, i.e. before it's loaded. Other methods are also called on this class.

Suggested fix: Move the logic to load the tidyall subclass back into the tidyall script. Open question: Do we need to leave it in Code::TidyAll?

@shlomif
Copy link
Contributor

shlomif commented Sep 30, 2020

@2shortplanks : I can confirm that this is still an issue here (fedora linux v32 x86-64).

shlomif added a commit to shlomif/perl-code-tidyall that referenced this issue Nov 2, 2021
@shlomif
Copy link
Contributor

shlomif commented Nov 2, 2021

See shlomif@2f20d3c for a proposed fix. Note that I spent most time yesterday getting the existing tests to pass locally.

shlomif added a commit to shlomif/perl-code-tidyall that referenced this issue Nov 24, 2021
@shlomif shlomif mentioned this issue Nov 24, 2021
autarch pushed a commit that referenced this issue Nov 24, 2021
autarch pushed a commit that referenced this issue Nov 24, 2021
autarch pushed a commit that referenced this issue Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants