-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Community members; other minor changes #234
Conversation
Updated position holders of Communities
✔️ Deploy Preview for houseofgeeks ready! 🔨 Explore the source changes: 40c8a23 🔍 Inspect the deploy log: https://app.netlify.com/sites/houseofgeeks/deploys/613318de02ac780007b7e394 😎 Browse the preview: https://deploy-preview-234--houseofgeeks.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a bit of cleanup required.
@@ -16,6 +17,10 @@ function ElectronicsMembers() { | |||
<a className="text-white" target="_blank" rel="noopener noreferrer" href={elcList.linkedin}> | |||
<LinkedIn className="icons-members"></LinkedIn> | |||
|
|||
</a> | |||
<a className="text-white" target="_blank" rel="noopener noreferrer" href={elcList.github}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 😄
Wait I've never had a review update, do I create a new pr? 😅 |
Nope. Just push new commits to |
Right. Good to know that Github takes the stress here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good job @SrijanSriv! Welcome to the contributor's club 🌟 @all-contributors please add @SrijanSriv for code |
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 5176 |
The website isn't updated. https://houseofgeeks.netlify.app/members I think @ankiiitraj needs to retrigger the deployment. |
@all-contributors please add @SrijanSriv for code |
I've put up a pull request to add @SrijanSriv! 🎉 |
Fixes #227
Description: The latest batch of Community members have been added to the respective places. Furthermore, I realized not all the images were being rendered since some folders had spaces in their paths (e.g. ./images/members/ webd and appd/...), so after some discussion, that was fixed as well. Attached is the same issue.Checklist
Testimonial