Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Community members; other minor changes #234

Merged
merged 5 commits into from
Sep 4, 2021

Conversation

SrijanSriv
Copy link
Member

@SrijanSriv SrijanSriv commented Sep 4, 2021

Fixes #227

Description: The latest batch of Community members have been added to the respective places. Furthermore, I realized not all the images were being rendered since some folders had spaces in their paths (e.g. ./images/members/ webd and appd/...), so after some discussion, that was fixed as well. Attached is the same issue.

Checklist

  • I've followed the Contributing guidelines provided in the repository.
  • I've made the changes that were demanded in the linked issue.
  • I've tested my code on a Chromium-based browser.
  • I've tested my code on Mozilla Firefox.
  • My code gave a clean console on debugging. (no warnings/errors)

Testimonial

image

@netlify
Copy link

netlify bot commented Sep 4, 2021

✔️ Deploy Preview for houseofgeeks ready!

🔨 Explore the source changes: 40c8a23

🔍 Inspect the deploy log: https://app.netlify.com/sites/houseofgeeks/deploys/613318de02ac780007b7e394

😎 Browse the preview: https://deploy-preview-234--houseofgeeks.netlify.app/

Copy link
Member

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a bit of cleanup required.

client/src/components/Members/Community/ElcMembersList.js Outdated Show resolved Hide resolved
@@ -16,6 +17,10 @@ function ElectronicsMembers() {
<a className="text-white" target="_blank" rel="noopener noreferrer" href={elcList.linkedin}>
<LinkedIn className="icons-members"></LinkedIn>

</a>
<a className="text-white" target="_blank" rel="noopener noreferrer" href={elcList.github}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 😄

client/src/components/Members/Community/WebMembersList.js Outdated Show resolved Hide resolved
@SrijanSriv
Copy link
Member Author

Wait I've never had a review update, do I create a new pr? 😅

@EmperorYP7
Copy link
Member

Wait I've never had a review update, do I create a new pr? 😅

Nope. Just push new commits to SrijanSriv:front-end

@SrijanSriv
Copy link
Member Author

Right. Good to know that Github takes the stress here.

Copy link
Member

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmperorYP7 EmperorYP7 merged commit 933b290 into houseofgeeks:front-end Sep 4, 2021
@EmperorYP7
Copy link
Member

Good job @SrijanSriv! Welcome to the contributor's club 🌟

@all-contributors please add @SrijanSriv for code

@allcontributors
Copy link
Contributor

@EmperorYP7

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 5176

@EmperorYP7
Copy link
Member

The website isn't updated. https://houseofgeeks.netlify.app/members

I think @ankiiitraj needs to retrigger the deployment.

@tusharjain0022
Copy link
Member

@all-contributors please add @SrijanSriv for code

@allcontributors
Copy link
Contributor

@tusharjain0022

I've put up a pull request to add @SrijanSriv! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Members] Update position holders of communities
3 participants