Improve ColumnWriteBuffer recycling

Return buffers to the pool after executing prepared INSERT statement, so they can be reused again even if statement is not closed
housepower · Dec 23, 2021 · bb66e4b · bb66e4b
1 parent 830d40e
commit bb66e4b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...src/main/java/com/github/housepower/jdbc/statement/ClickHousePreparedInsertStatement.java b/...src/main/java/com/github/housepower/jdbc/statement/ClickHousePreparedInsertStatement.java
@@ -130,7 +130,7 @@ public int executeUpdate() throws SQLException {
         addParameters();
         int result = connection.sendInsertRequest(block);
         this.blockInit = false;
-        this.block.initWriteBuffer();
+        this.block.cleanup();
         return result;
     }
 
@@ -156,7 +156,7 @@ public int[] executeBatch() throws SQLException {
         Arrays.fill(result, 1);
         clearBatch();
         this.blockInit = false;
-        this.block.initWriteBuffer();
+        this.block.cleanup();
         return result;
     }
 
@@ -166,7 +166,6 @@ public void close() throws SQLException {
             // Empty insert when close.
             this.connection.sendInsertRequest(new Block());
             this.blockInit = false;
-            this.block.initWriteBuffer();
         }
         // clean up block on close
         this.block.cleanup();

diff --git a/...e-native-jdbc/src/main/java/com/github/housepower/jdbc/statement/ClickHouseStatement.java b/...e-native-jdbc/src/main/java/com/github/housepower/jdbc/statement/ClickHouseStatement.java
@@ -86,6 +86,7 @@ public int executeUpdate(String query) throws SQLException {
                 block.initWriteBuffer();
                 new ValuesNativeInputFormat(matcher.end() - 1, query).fill(block);
                 updateCount = connection.sendInsertRequest(block);
+                block.cleanup();
                 return updateCount;
             }
             updateCount = -1;