Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the name of the type instead of the name of the column #367

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

alitaker
Copy link
Contributor

getColumns returns wrong metadata because it was returning the name of the column instead of the name of the datatype

Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #367 (954c112) into master (43d7d6d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #367   +/-   ##
=========================================
  Coverage     61.90%   61.90%           
  Complexity     1192     1192           
=========================================
  Files           131      131           
  Lines          6418     6418           
  Branches        475      475           
=========================================
  Hits           3973     3973           
  Misses         2178     2178           
  Partials        267      267           
Impacted Files Coverage Δ
...ub/housepower/jdbc/ClickHouseDatabaseMetadata.java 91.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d7d6d...954c112. Read the comment docs.

@sundy-li sundy-li merged commit 701baaf into housepower:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants