Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Date32 support #375

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

liuneng1994
Copy link
Contributor

@liuneng1994 liuneng1994 commented Sep 28, 2021

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #375 (9c6ab44) into master (0ca2e83) will decrease coverage by 0.06%.
The diff coverage is 46.66%.

❗ Current head 9c6ab44 differs from pull request most recent head fdd1217. Consider uploading reports for the commit fdd1217 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #375      +/-   ##
============================================
- Coverage     61.97%   61.90%   -0.07%     
- Complexity     1222     1230       +8     
============================================
  Files           133      134       +1     
  Lines          6549     6579      +30     
  Branches        502      508       +6     
============================================
+ Hits           4059     4073      +14     
- Misses         2214     2228      +14     
- Partials        276      278       +2     
Impacted Files Coverage Δ
...c/statement/ClickHousePreparedInsertStatement.java 52.63% <40.00%> (-0.39%) ⬇️
...om/github/housepower/data/type/DataTypeDate32.java 45.83% <45.83%> (ø)
...va/com/github/housepower/data/DataTypeFactory.java 87.69% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca2e83...fdd1217. Read the comment docs.

@sundy-li
Copy link
Member

sundy-li commented Sep 28, 2021

Date32 is not started from epoch?

From clickhouse doc

A date. Supports the date range same with Datetime64. Stored in four bytes as the number of days since 1925-01-01. Allows storing values till 2283-11-11.

@liuneng1994
Copy link
Contributor Author

Date32 is not started from epoch?

From clickhouse doc

A date. Supports the date range same with Datetime64. Stored in four bytes as the number of days since 1925-01-01. Allows storing values till 2283-11-11.

Date32 is start from 1925-01-01, like DateTime64. It can be a negative value

@sundy-li
Copy link
Member

Oh, I see now.

@sundy-li sundy-li merged commit f99ab4e into housepower:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants