Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove final of buffer size in ClickHouseDefines #387

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Remove final of buffer size in ClickHouseDefines #387

merged 2 commits into from
Dec 3, 2021

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Dec 3, 2021

@codecov
Copy link

codecov bot commented Dec 3, 2021 •
edited
Loading

Codecov Report

Merging #387 (ff9eb21) into master (c101a42) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #387      +/-   ##
============================================
+ Coverage     62.37%   62.40%   +0.02%     
- Complexity     1248     1249       +1     
============================================
  Files           135      135              
  Lines          6631     6636       +5     
  Branches        516      516              
============================================
+ Hits           4136     4141       +5     
  Misses         2219     2219              
  Partials        276      276
Impacted Files Coverage Δ
.../github/housepower/settings/ClickHouseDefines.java 83.33% <100.00%> (+83.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c101a42...ff9eb21. Read the comment docs.

@pan3793 pan3793 merged commit 7a275c9 into master Dec 3, 2021
@pan3793 pan3793 deleted the buf branch December 3, 2021 09:22
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

BENCHMARK_REPORT 
Benchmark                                                  (batchSize)  (columnNum)  (selectNumber)  Mode  Cnt      Score   Error  Units
InsertIBenchmark.benchInsertHttp                                200000           20             N/A  avgt         325.076          ms/op
InsertIBenchmark.benchInsertHttp                                200000           50             N/A  avgt         301.419          ms/op
InsertIBenchmark.benchInsertHttp                                500000           20             N/A  avgt         812.555          ms/op
InsertIBenchmark.benchInsertHttp                                500000           50             N/A  avgt         809.642          ms/op
InsertIBenchmark.benchInsertNative                              200000           20             N/A  avgt          99.103          ms/op
InsertIBenchmark.benchInsertNative                              200000           50             N/A  avgt         100.542          ms/op
InsertIBenchmark.benchInsertNative                              500000           20             N/A  avgt         234.868          ms/op
InsertIBenchmark.benchInsertNative                              500000           50             N/A  avgt         229.077          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary              200000           20             N/A  avgt         146.424          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary              200000           50             N/A  avgt         634.520          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary              500000           20             N/A  avgt         656.409          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary              500000           50             N/A  avgt        1823.397          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative                     200000           20             N/A  avgt         394.477          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative                     200000           50             N/A  avgt        1027.360          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative                     500000           20             N/A  avgt         924.408          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative                     500000           50             N/A  avgt        2448.718          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary                 200000           20             N/A  avgt         143.137          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary                 200000           50             N/A  avgt         228.401          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary                 500000           20             N/A  avgt         205.765          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary                 500000           50             N/A  avgt         821.767          ms/op
RowBinaryIntIBenchmark.benchInsertNative                        200000           20             N/A  avgt         319.210          ms/op
RowBinaryIntIBenchmark.benchInsertNative                        200000           50             N/A  avgt         843.223          ms/op
RowBinaryIntIBenchmark.benchInsertNative                        500000           20             N/A  avgt         784.638          ms/op
RowBinaryIntIBenchmark.benchInsertNative                        500000           50             N/A  avgt        2014.985          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary              200000           20             N/A  avgt         414.027          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary              200000           50             N/A  avgt        1044.262          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary              500000           20             N/A  avgt        1019.813          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary              500000           50             N/A  avgt        2521.985          ms/op
RowBinaryStringIBenchmark.benchInsertNative                     200000           20             N/A  avgt         602.393          ms/op
RowBinaryStringIBenchmark.benchInsertNative                     200000           50             N/A  avgt        1539.579          ms/op
RowBinaryStringIBenchmark.benchInsertNative                     500000           20             N/A  avgt        1562.064          ms/op
RowBinaryStringIBenchmark.benchInsertNative                     500000           50             N/A  avgt        4008.941          ms/op
SelectIBenchmark.benchSelectHTTP                                   N/A          N/A          500000  avgt        1367.589          ms/op
SelectIBenchmark.benchSelectHTTP                                   N/A          N/A        10000000  avgt       25938.343          ms/op
SelectIBenchmark.benchSelectNative                                 N/A          N/A          500000  avgt         298.183          ms/op
SelectIBenchmark.benchSelectNative                                 N/A          N/A        10000000  avgt        5322.122          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp                200000           20             N/A  avgt         691.082          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp                200000           50             N/A  avgt        1883.516          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp                500000           20             N/A  avgt        1768.386          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp                500000           50             N/A  avgt        4661.178          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative              200000           20             N/A  avgt         385.641          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative              200000           50             N/A  avgt        1031.086          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative              500000           20             N/A  avgt         929.242          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative              500000           50             N/A  avgt        2454.979          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp                   200000           20             N/A  avgt         364.155          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp                   200000           50             N/A  avgt         895.928          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp                   500000           20             N/A  avgt         967.058          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp                   500000           50             N/A  avgt        2260.244          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative                 200000           20             N/A  avgt         319.961          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative                 200000           50             N/A  avgt         817.289          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative                 500000           20             N/A  avgt         791.906          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative                 500000           50             N/A  avgt        2044.847          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp                200000           20             N/A  avgt         541.403          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp                200000           50             N/A  avgt        1330.190          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp                500000           20             N/A  avgt        1381.098          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp                500000           50             N/A  avgt        3436.107          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative              200000           20             N/A  avgt         633.979          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative              200000           50             N/A  avgt        1580.456          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative              500000           20             N/A  avgt        1628.897          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative              500000           50             N/A  avgt        4029.272          ms/op

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

BENCHMARK_REPORT 
Benchmark                                                  (batchSize)  (columnNum)  (selectNumber)  Mode  Cnt      Score   Error  Units
InsertIBenchmark.benchInsertHttp                                200000           20             N/A  avgt         403.491          ms/op
InsertIBenchmark.benchInsertHttp                                200000           50             N/A  avgt         377.257          ms/op
InsertIBenchmark.benchInsertHttp                                500000           20             N/A  avgt         935.052          ms/op
InsertIBenchmark.benchInsertHttp                                500000           50             N/A  avgt         972.366          ms/op
InsertIBenchmark.benchInsertNative                              200000           20             N/A  avgt         125.324          ms/op
InsertIBenchmark.benchInsertNative                              200000           50             N/A  avgt         126.159          ms/op
InsertIBenchmark.benchInsertNative                              500000           20             N/A  avgt         297.836          ms/op
InsertIBenchmark.benchInsertNative                              500000           50             N/A  avgt         291.898          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary              200000           20             N/A  avgt         177.182          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary              200000           50             N/A  avgt         842.894          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary              500000           20             N/A  avgt         838.679          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary              500000           50             N/A  avgt        2775.999          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative                     200000           20             N/A  avgt         455.874          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative                     200000           50             N/A  avgt        1242.048          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative                     500000           20             N/A  avgt        1117.041          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative                     500000           50             N/A  avgt        3066.499          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary                 200000           20             N/A  avgt         177.239          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary                 200000           50             N/A  avgt         423.770          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary                 500000           20             N/A  avgt         245.267          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary                 500000           50             N/A  avgt         625.374          ms/op
RowBinaryIntIBenchmark.benchInsertNative                        200000           20             N/A  avgt         382.824          ms/op
RowBinaryIntIBenchmark.benchInsertNative                        200000           50             N/A  avgt         992.190          ms/op
RowBinaryIntIBenchmark.benchInsertNative                        500000           20             N/A  avgt         927.962          ms/op
RowBinaryIntIBenchmark.benchInsertNative                        500000           50             N/A  avgt        2530.584          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary              200000           20             N/A  avgt         485.540          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary              200000           50             N/A  avgt        1188.236          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary              500000           20             N/A  avgt        1208.515          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary              500000           50             N/A  avgt        3091.050          ms/op
RowBinaryStringIBenchmark.benchInsertNative                     200000           20             N/A  avgt         718.481          ms/op
RowBinaryStringIBenchmark.benchInsertNative                     200000           50             N/A  avgt        1934.497          ms/op
RowBinaryStringIBenchmark.benchInsertNative                     500000           20             N/A  avgt        1780.904          ms/op
RowBinaryStringIBenchmark.benchInsertNative                     500000           50             N/A  avgt        5059.895          ms/op
SelectIBenchmark.benchSelectHTTP                                   N/A          N/A          500000  avgt        1809.414          ms/op
SelectIBenchmark.benchSelectHTTP                                   N/A          N/A        10000000  avgt       33347.515          ms/op
SelectIBenchmark.benchSelectNative                                 N/A          N/A          500000  avgt         368.328          ms/op
SelectIBenchmark.benchSelectNative                                 N/A          N/A        10000000  avgt        6605.827          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp                200000           20             N/A  avgt         911.860          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp                200000           50             N/A  avgt        2323.738          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp                500000           20             N/A  avgt        2232.478          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp                500000           50             N/A  avgt        5757.497          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative              200000           20             N/A  avgt         453.266          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative              200000           50             N/A  avgt        1220.478          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative              500000           20             N/A  avgt        1122.201          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative              500000           50             N/A  avgt        3045.696          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp                   200000           20             N/A  avgt         452.459          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp                   200000           50             N/A  avgt        1127.067          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp                   500000           20             N/A  avgt        1179.042          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp                   500000           50             N/A  avgt        2814.023          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative                 200000           20             N/A  avgt         385.746          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative                 200000           50             N/A  avgt        1016.053          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative                 500000           20             N/A  avgt         954.216          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative                 500000           50             N/A  avgt        2500.270          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp                200000           20             N/A  avgt         678.534          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp                200000           50             N/A  avgt        1631.000          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp                500000           20             N/A  avgt        1696.777          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp                500000           50             N/A  avgt        4196.467          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative              200000           20             N/A  avgt         710.611          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative              200000           50             N/A  avgt        1888.306          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative              500000           20             N/A  avgt        1882.866          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative              500000           50             N/A  avgt        4878.720          ms/op

pan3793 added a commit that referenced this pull request Dec 3, 2021
@pan3793
Remove final of buffer size in ClickHouseDefines (#387)
a8d3ada 
* Remove final of buf size in ClickHouseDefines

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pan3793