Fix Nothing DataType serde #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
============================================
+ Coverage 62.41% 62.43% +0.02%
- Complexity 1249 1250 +1
============================================
Files 135 135
Lines 6638 6640 +2
Branches 516 516
============================================
+ Hits 4143 4146 +3
Misses 2219 2219
+ Partials 276 275 -1
Continue to review full report at Codecov.
|
pan3793
reviewed
Dec 13, 2021
| import com.github.housepower.misc.SQLLexer; | ||
| import com.github.housepower.serde.BinaryDeserializer; | ||
| import com.github.housepower.serde.BinarySerializer; | ||
|
|
||
| import java.io.IOException; | ||
| import java.sql.SQLException; | ||
| import java.sql.Types; |
There was a problem hiding this comment.
the import order changed again...
pan3793
reviewed
Dec 13, 2021
...house-native-jdbc/src/main/java/com/github/housepower/data/type/complex/DataTypeNothing.java
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Dec 13, 2021
...house-native-jdbc/src/main/java/com/github/housepower/data/type/complex/DataTypeNothing.java
Outdated
Show resolved
Hide resolved
|
Let's avoid unnecessary changes to make this patch portable |
pan3793
approved these changes
Dec 13, 2021
pan3793
pushed a commit
that referenced
this pull request
Dec 22, 2021
* Fix Nothing DataType serde * Fix Nothing DataType serde * Fix Nothing DataType serde * Fix Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389