Skip to content

fix MOE lint #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2025
Merged

fix MOE lint #2

merged 3 commits into from
Apr 5, 2025

Conversation

@luccafong
Copy link
Collaborator

@luccafong luccafong commented Apr 5, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@luccafong luccafong changed the title fix lint fix MOE lint Apr 5, 2025
houseroad
houseroad approved these changes Apr 5, 2025
View reviewed changes
vllm/model_executor/layers/fused_moe/layer.py Outdated

class FusedMoEMethodBase(QuantizeMethodBase):
supports_apply_router_weight_on_input: bool = False

Copy link
Owner

@houseroad houseroad Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

houseroad
houseroad reviewed Apr 5, 2025
View reviewed changes
vllm/model_executor/layers/fused_moe/layer.py
scoring_func=scoring_func,
e_score_correction_bias=e_score_correction_bias,
activation=activation)
return self.forward(
Copy link
Owner

@houseroad houseroad Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we may need to follow the coding style.

@houseroad houseroad merged commit ec6cdaa into init_pr Apr 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luccafong @houseroad