Add apply_router_weight_on_input to all FusedMoEMethodBase classes #5
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
this should be above "activation", if you run "pre-commit run --show-diff-on-failure --color=always --all-files --hook-stage manual" there would be a failure that it does not compatible with the base signature
| scoring_func=scoring_func, | ||
| e_score_correction_bias=e_score_correction_bias) | ||
|
|
||
| return fused_experts(x, |
There was a problem hiding this comment.
nit: this seems no need to change, the format previously is following vllm format style
There was a problem hiding this comment.
formatted changed it because we are passing apply_router_weight_on_input=apply_router_weight_on_input now
This reverts commit 675b3c1.
fused moe layer will now pass this arg to FusedMoEMethodBase child classes
ran
pre-commit run --show-diff-on-failure --color=always --all-files --hook-stage manualto keep linter happyAddress
https://buildkite.com/vllm/ci/builds/16963#019607e4-941e-4455-ac59-78ef198bd947/54