Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chrome tabs being unresponsive after break #793

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

BenediktAllendorf
Copy link
Contributor

@BenediktAllendorf BenediktAllendorf commented Dec 7, 2020

Issue: closes #783

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • issue was opened to discuss proposed changes before starting implementation. It is important do discuss changes before implementing them (Why should we add it? How should it work? How should it look? Where will it be? ...).
  • during development, node version specified in package.json was used (ie using nvm).
  • package versions and package-lock.json were not changed (npm install --no-save).
  • app version number was not changed.
  • all new code has tests to ensure against regressions.
  • npm run lint reports no offenses.
  • npm run test is error-free.
  • README and CHANGELOG were updated accordingly.
  • after PR is approved, all commits in it are squashed

Description of the Change

Fixed the issue of chrome and edge tabs being non-responsive when resuming after a break.

Other information

Not sure if this is an electron or chrome/edge bug and this feels more a workaround than a real fix.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #793 (908e35c) into master (d81c008) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files          12       12           
  Lines         321      321           
=======================================
  Hits          237      237           
  Misses         84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81c008...908e35c. Read the comment docs.

@hovancik
Copy link
Owner

hovancik commented Dec 7, 2020

Works fine on Linux :)

@hovancik
Copy link
Owner

hovancik commented Dec 7, 2020

Seems to be fine on mac as well..

@hovancik hovancik merged commit 7b3a02c into hovancik:master Dec 7, 2020
@BenediktAllendorf BenediktAllendorf deleted the hide_and_close branch June 24, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser tab non-responsive after resuming
2 participants