Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tech] [doc] test doc examples #782

Closed
wants to merge 1 commit into from

Conversation

pbougue
Copy link
Contributor

@pbougue pbougue commented May 18, 2021

After https://github.com/CanalTP/transit_model/pull/780/files#r629252682
Renaming the zip files after their move will be required (and a pain point).
So maybe not worth keeping all this, but tested what was missing to activate all doc-test 🤷

@antoine-de
Copy link
Contributor

fine for me, a real doc test is always better, but reqwest was removed previously because of the impact on the build time

@pbougue pbougue force-pushed the simplier_gtfs_api branch from bc4f53e to 8f56d51 Compare May 18, 2021 15:27
@datanel datanel closed this May 19, 2021
@datanel datanel deleted the branch hove-io:simplier_gtfs_api May 19, 2021 07:44
@pbougue
Copy link
Contributor Author

pbougue commented May 20, 2021

4 options:

  1. No http-client deps
    a. let it as-is (ignored)
    b. use file read + comment that it could be reqwest
  2. We can check https://blog.logrocket.com/the-state-of-rust-http-clients/ for light http clients (ureq, http_req).
    Or add reqwest back to check if it's OK for compile times.
    a. add dev-deps
    b. add complete deps (and real url-read)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants