Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAV-3235] Feature: odt reservation #953

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Conversation

datanel
Copy link
Member

@datanel datanel commented Jul 23, 2024

@datanel datanel marked this pull request as draft July 23, 2024 16:33
@datanel datanel force-pushed the feature/nav-3093/odt-reservation branch from f88d2b8 to 44637a1 Compare July 24, 2024 10:10
@datanel datanel marked this pull request as ready for review July 24, 2024 10:12
@datanel datanel force-pushed the feature/nav-3093/odt-reservation branch 2 times, most recently from f490008 to fab8814 Compare July 24, 2024 15:51
@datanel datanel force-pushed the feature/nav-3093/odt-reservation branch from fab8814 to caa08f1 Compare July 25, 2024 16:03
@ArnaudOggy ArnaudOggy self-requested a review July 26, 2024 14:56
@ArnaudOggy
Copy link
Contributor

@datanel
Can you add this in model ?

impl ODTReservation {
    pub fn is_similar(&self, other: &Self) -> bool {
        self.url == other.url && 
        self.phone == other.phone && 
        self.conditions == other.conditions && 
        self.deeplink == other.deeplink
    }
}

We will need it, and it will avoid sanitize deduplication

@datanel
Copy link
Member Author

datanel commented Jul 29, 2024

@datanel Can you add this in model ?

impl ODTReservation {
    pub fn is_similar(&self, other: &Self) -> bool {
        self.url == other.url && 
        self.phone == other.phone && 
        self.conditions == other.conditions && 
        self.deeplink == other.deeplink
    }
}

We will need it, and it will avoid sanitize deduplication

done

@datanel datanel merged commit b00bdbb into master Jul 30, 2024
13 checks passed
@datanel datanel deleted the feature/nav-3093/odt-reservation branch July 30, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants