Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

remove dependence on deprecated request library #1936

Closed
benbrown opened this issue Mar 17, 2020 · 5 comments
Closed

remove dependence on deprecated request library #1936

benbrown opened this issue Mar 17, 2020 · 5 comments
Milestone
4.9

Comments

@benbrown
Copy link
Contributor

Since request is now marked as deprecated, let's remove it from the library for something more modern.

https://github.com/request/request#readme
@benbrown benbrown added this to the 4.9 milestone Mar 17, 2020
@stale
Copy link

stale bot commented May 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 16, 2020
@benbrown benbrown removed the stale label May 20, 2020
@stale
Copy link

stale bot commented Jul 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 19, 2020
@benbrown
Copy link
Contributor Author

not stale!

@stale stale bot removed the stale label Jul 20, 2020
benbrown added a commit that referenced this issue Aug 21, 2020
@benbrown
fix for #1936 - remove dependency on request
3f79353
@benbrown
Copy link
Contributor Author

Done!

@bobisapotato bobisapotato mentioned this issue Jan 24, 2021
Merged
@bratanon
Copy link

The botbuilder-adapter-slack is still using this which results in Error: Cannot find module 'request'.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9
Development

No branches or pull requests
2 participants
@benbrown @bratanon