Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

pass error object to the callbacks for failed send Api calls #1147

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

nishch
Copy link
Contributor

@nishch nishch commented Nov 27, 2017

Fix for #1146

Copy link
Contributor

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use Facebook (bot), but this change looks correct to me.

@ouadie-lahdioui
Copy link
Collaborator

@nishant-chaturvedi LGTM 👍

NB: It will be break changes for the users who wait for a simple string message and not an error object.

@benbrown benbrown merged commit 5d237d5 into howdyai:master Jan 11, 2018
@benbrown
Copy link
Contributor

thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants