This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Fix #1279 #1301
Merged
Fix #1279 #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this mostly makes sense. To avoid breaking anybody, could you loop through the parameters as provided in message and ensure they have content_type set, and if not set it to text? This lets people exclude that field in the simplest cases. |
|
Done 👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In this PR i replaced the internat core quick replies format mechanism by quick replies from message object.
This way will prevent us adding new supported quick replies each time fb adds ones.
FYI FB truncates the quick reply title by default, i also removed
titleLimitWDYT ?