This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Check if a new message is from the bot using the bot's id instead of … #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…email
On August 31st, 2018 all bots with the sparkbot.io domain name will be renamed with a webex.bot domain. Today in botkit, the Webex Teams code compares the bot's email with the message senders email to filter out messages from itself. If this code is running on August 31st the bot will start responding to its own messages.
A restart that day will fix the problem, but using a version of botkit with this PR merged will avoid the problem all together. The changes is to simply compare the id of the message sender against the id of the bot. See this blog post: https://developer.webex.com/blog/blog-details-9878.html
It is worth noting that I am not familar with the conversations feature of botkit and I have not updated the code to us ids for conversations. At worst I think this will impact bot conversations that start before August 31, 2018, and continue after.