Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Remove Botkit Studio metrics features #1544

Merged
merged 3 commits into from
Dec 14, 2018
Merged

Remove Botkit Studio metrics features #1544

merged 3 commits into from
Dec 14, 2018

Conversation

benbrown
Copy link
Contributor

This pull request beings the process of removing Botkit Studio features from Botkit core.

In particular, this PR:

  • Removes calls to Botkit Studio's metrics APIs
  • Removes all metrics/stats features
  • Removes the user id parameter from calls to Botkit Studio's content management APIs

@benbrown benbrown mentioned this pull request Dec 12, 2018
Closed
6 tasks
@benbrown benbrown added the next_release this issue is accepted for inclusion in the next release of botkit label Dec 12, 2018
ouadie-lahdioui
ouadie-lahdioui approved these changes Dec 13, 2018
View reviewed changes
Copy link
Collaborator

@ouadie-lahdioui ouadie-lahdioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benbrown benbrown merged commit 9487f30 into master Dec 14, 2018
@benbrown benbrown deleted the benbrown/remove_metrics branch May 8, 2019 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@peterswimm peterswimm peterswimm approved these changes

@ouadie-lahdioui ouadie-lahdioui ouadie-lahdioui approved these changes

Assignees
No one assigned
Labels
next_release this issue is accepted for inclusion in the next release of botkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbrown @peterswimm @ouadie-lahdioui