This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
(Webex) Remove files key with empty string value
#1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes sending `files` key with empty string value when there are no files while sending a message. `files` key with empty string is causing API to fail with below `BadRequest: "Unable to retrieve content."`. I have validated that by sending request to webex api from webex developer console. Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
|
|
|
I was trying webex adapter with botbuilder and I was able to get my bot app running and getting webhook callback from webex but it was not able to send the messages. It was failing with below error. After some investigation, I found that it was sending So It will be good idea to remove this key and send only if there are files. |
viveksyngh
changed the title
files key with empty string valuefiles key with empty string value
benbrown
approved these changes
Mar 11, 2020
|
Included in the next release -> #1929 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes sending
fileskey with empty string value whenthere are no files while sending a message.
fileskey with empty string is causing API to failwith below
BadRequest: "Unable to retrieve content.". I have validatedthat by sending request to webex api from webex developer console.
Signed-off-by: Vivek Singh vivekkmr45@yahoo.in