This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Removes enforcement of "as_user" field. Fixes #1943 #1944
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1943
By removing this IF statement:
New generation bots will be able to make use of
icon_url
,icon_emoji
andusername
fields on thereply
object without having Botkit forcing a deprecated fieldas_user
set to false.For classic bots, developers would still be able to add the
as_user
field manually as stated by the Slack documentation(I'm not sure if I should make a PR to master or other branch, please advice)