This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Fix unhandled promise rejections when a trigger errors #1983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a trigger, such as the callback to
controller.hears(...)
errors (the async callback rejects), this promise is not handled correctly, and results in an unhandled promise rejection.This is because the
run
function forware
does not support promises (the middleware themselves do, but not the callback).I don't really agree with the decision to use a non-promise-supporting library like
ware
in this very promise-based framework, but we can at least promisify those calls.This ends up simplifying a lot of the code that uses the middleware, as Promise constructors no longer need to be used.
With this fix, the promises bubble up all the way to the
handleTurn
function, and can be handled at the web layer.Maybe a
controller.on('error', () => {})
event would make sense as well. Or anerror
middleware?