22346: Fixes issue when changing an opcode's type to an assoc where k…

…eys would be lost and turned into empty strings (#317)

src/Amalgam/evaluablenode/EvaluableNode.cpp

@@ -660,14 +660,11 @@ void EvaluableNode::SetType(EvaluableNodeType new_type, EvaluableNodeManager *en
 			new_ordered.reserve(2 * mcn.size());
 			for(auto &[cn_id, cn] : mcn)
 			{
-				//keep the reference from when it was an assoc
-				new_ordered.push_back(enm->AllocNodeWithReferenceHandoff(ENT_STRING, cn_id));
+				EvaluableNode *key = Parser::ParseFromKeyStringId(cn_id, enm);
+				new_ordered.push_back(key);
 				new_ordered.push_back(cn);
 			}
 
-			//clear the mapped nodes here, because don't want to free the references
-			// as they were handed off to the newly allocated ordered child nodes
-			mcn.clear();
 			InitOrderedChildNodes();
 			//swap for efficiency
 			swap(GetOrderedChildNodesReference(), new_ordered);

src/Amalgam/evaluablenode/EvaluableNodeTreeFunctions.cpp

@@ -243,7 +243,6 @@ EvaluableNode *GetTraversalPathListFromAToB(EvaluableNodeManager *enm, Evaluable
 		&& b_ancestor != a		//stop if it's the target
 		&& nodes_visited.insert(b_ancestor_parent).second == true) //make sure not visited yet
 	{
-
 		//find where the node matches
 		if(b_ancestor_parent->IsAssociativeArray())
 		{