Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20490: Unifies .nas, and .nan under null keyword, MAJOR #155

Merged
merged 17 commits into from
Jun 25, 2024
Merged

20490: Unifies .nas, and .nan under null keyword, MAJOR #155

merged 17 commits into from
Jun 25, 2024

Conversation

howsohazard
Copy link
Contributor

.nas and .nan have been removed and have been replaced simply by (null)

howsohazard and others added 15 commits June 18, 2024 23:05
@howsohazard
20490: Begins effort unifying null values
5c236aa
@howsohazard
20490: Minor fix
ae6f92d
@howsohazard
20490: Documentation updates
7b60d2b
@howsohazard
20490: More implementation
1b53825
@howsohazard
20490: More implementation progress
b4de819
@howsohazard
20490: Fixes data traversal bug
2f78d15
@howsohazard
20490: Fixes to unit tests
93703f9
@howsohazard
20490: Implementation progress
18d6168
@howsohazard
20490: Fixes accum bug
fec21eb
@howsohazard
20490: Removed remaining .nan
00e2fdb
@howsohazard
20490: Minor cleanup
d41f566
@cademack
20655: Initializes EvaluableNode to type ENT_NULL if double value is …
9cfb748 
…NaN (#156)

Note, this merges into branch 20490, not main
@cademack
20662: Fixes (null)'s returned by ENT_CURRENT_INDEX to have correct t…
c261a4b 
…yping/node information (#157)
@cademack
20668: Fixes (null)'s returned by (indices) to be typed as null (#…
617bc4b 
…158)

The diff here is rendered strangely.
@howsohazard
20490: Updates out.txt
e80aa21
@howsohazard howsohazard marked this pull request as ready for review June 25, 2024 20:15
@howsohazard howsohazard requested a review from a team as a code owner June 25, 2024 20:15
cademack
cademack previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@cademack cademack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine enough

src/Amalgam/SeparableBoxFilterDataStore.cpp Outdated Show resolved Hide resolved
cademack
cademack previously approved these changes Jun 25, 2024
View reviewed changes
@howsohazard howsohazard merged commit 7d51dea into main Jun 25, 2024
20 checks passed
@howsohazard howsohazard deleted the 20490-null-unification branch June 25, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howsoRes howsoRes howsoRes approved these changes

@cademack cademack cademack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howsohazard @cademack @howsoRes