Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21695: Fixes WASM debug build, packaging updates #274

Merged
merged 43 commits into from
Oct 16, 2024
Merged

21695: Fixes WASM debug build, packaging updates #274

merged 43 commits into from
Oct 16, 2024

Conversation

apbassett
Copy link
Member

@apbassett apbassett commented Sep 30, 2024 •
edited
Loading

  • Fixes issue where WASM debug build did not actually have debug information available
  • Adds web to sENVIRONMENTS linker flag
  • Removes quiet mode from CI/CD build step for future debugability
  • Splits build process into separate release/debug phases for WASM instead of shoehorning a debug build into the release build

@apbassett apbassett requested a review from a team as a code owner September 30, 2024 18:36
@apbassett apbassett mentioned this pull request Sep 30, 2024
Merged
@lancegliser lancegliser mentioned this pull request Oct 9, 2024
Closed
@apbassett apbassett force-pushed the wasm-debug branch 2 times, most recently from eaf164d to 2444d4b Compare October 10, 2024 13:51
@apbassett apbassett merged commit 9fdeb9f into main Oct 16, 2024
21 checks passed
@apbassett apbassett deleted the wasm-debug branch October 16, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lancegliser lancegliser lancegliser left review comments

@fulpm fulpm fulpm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apbassett @fulpm @lancegliser @howsohazard