Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18825: Adds NO_REENTRANCY_LOCKS to arm8a build #51

Merged
merged 7 commits into from
Jan 3, 2024
Merged

18825: Adds NO_REENTRANCY_LOCKS to arm8a build #51

merged 7 commits into from
Jan 3, 2024

Conversation

calebwherry
Copy link
Contributor

@calebwherry calebwherry commented Jan 2, 2024 •
edited
Loading

  • Removes potential for illegal instructions by compiling with NO_REENTRANCY_LOCKS on arm8a.
  • Adds platform specific sleep needed for NO_REENTRANCY_LOCKS addition.
  • Removes obsolete Platform_EnsurePreciseTiming method.
  • Adds missing TODOs for commented out CMake configs and code
  • Adds done message to create version script to know when that step is completed.

@calebwherry calebwherry requested a review from a team as a code owner January 2, 2024 17:03
@calebwherry calebwherry merged commit 008bf05 into main Jan 3, 2024
19 checks passed
@calebwherry calebwherry deleted the 18825-arm8a-lock-def-fix branch January 3, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howsohazard howsohazard howsohazard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebwherry @howsohazard