Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18982: Invalid JSON conversion now returns NaS (not-a-string) instead of an empty string #56

Merged
merged 13 commits into from
Jan 15, 2024

Conversation

calebwherry
Copy link
Contributor

@calebwherry calebwherry commented Jan 15, 2024

Also reduces length of some extra long function names.

@calebwherry calebwherry requested a review from a team as a code owner January 15, 2024 15:47
@calebwherry calebwherry changed the title 18982: Amalgam now returns NaS instead of empty string on invalid JSON 18982: Invalid JSON now returns NaS instead of an empty string Jan 15, 2024
@calebwherry calebwherry changed the title 18982: Invalid JSON now returns NaS instead of an empty string 18982: Invalid JSON conversion now returns NaS instead of an empty string Jan 15, 2024
@calebwherry calebwherry changed the title 18982: Invalid JSON conversion now returns NaS instead of an empty string 18982: Invalid JSON conversion now returns NaS (not-a-string) instead of an empty string Jan 15, 2024
howsohazard
howsohazard previously approved these changes Jan 15, 2024
@calebwherry calebwherry merged commit d229848 into main Jan 15, 2024
19 checks passed
@calebwherry calebwherry deleted the 18982-return-nas-on-invalid-json branch January 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants