This repository was archived by the owner on Mar 19, 2021. It is now read-only.
Feat/cards typography #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artalar
reviewed
Jun 27, 2019
src/ui/atoms/heading.js
Outdated
|
|
||
| export const H1 = styled.h1` | ||
| margin: ${(p) => (p.narrow ? 0 : 3)}rem 0; | ||
| /* margin: ${(p) => (p.narrow ? 0 : 3)}rem 0; */ |
| import { Routes } from "./routes" | ||
| import { GlobalStyles } from "./global-styles" | ||
|
|
||
| export const config = { | ||
| base: "14px", |
There was a problem hiding this comment.
Typographist requires base in pixels. Because pixels is absolute independent unit
sergeysova
suggested changes
Jun 28, 2019
| </GridCard> | ||
| </CardBox> | ||
| </CardNarrow> | ||
| <Rhythm> |
| @@ -1,7 +1,7 @@ | |||
| import React from "react" | |||
| import PropTypes from "prop-types" | |||
| import styled from "styled-components" | |||
| import { above } from "styled-breakpoints" | |||
| import { up } from "@typographist/styled" | |||
There was a problem hiding this comment.
Maybe remove styled-breakpoints from dependencies?
stuneak
reviewed
Jun 28, 2019
| user-select: none; | ||
| ` | ||
|
|
||
| H4.propTypes = { |
There was a problem hiding this comment.
Wouldn't it be better to use flow instead of proptypes?
sergeysova
approved these changes
Jul 1, 2019
|
@all-contributors please add @mg901 for design, code |
|
I've put up a pull request to add @mg901! 🎉 |
|
@all-contributors please add @artalar for review |
|
I've put up a pull request to add @artalar! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.