Skip to content

Fixing: Argument #1 ($array) must be of type array, null given #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2022
Merged

Fixing: Argument #1 ($array) must be of type array, null given #9

merged 3 commits into from
Apr 19, 2022

Conversation

@johnwedgbury
Copy link
Contributor

@johnwedgbury johnwedgbury commented Feb 7, 2022

In some cases $this->objects() can be null in an AbstractObjectCollection.

This throws:

TypeError
ArrayIterator::__construct(): Argument #1 ($array) must be of type array, null given

This PR forces an empty array in these cases.

@howyi
Copy link
Owner

howyi commented Apr 19, 2022

@johnwedgbury THANK YOU!

@howyi howyi merged commit 17dae68 into howyi:master Apr 19, 2022
@jrchamp jrchamp mentioned this pull request Jul 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howyi howyi howyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnwedgbury @howyi