config: add maxReqFilterSize #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newer nixpkgs have flatbuffers set to v24 which doesn't work
Add a configurable option for expanding the number of allowed filters
in REQ.
The motivation here is to support queries of this nature:
["REQ", "last-note-from-each-user",
{ "authors": [ "a" ], "kinds": [ 1 ], "limit": 1 },
{ "authors": [ "b" ], "kinds": [ 1 ], "limit": 1 },
{ "authors": [ "c" ], "kinds": [ 1 ], "limit": 1 },
{ "authors": [ "d" ], "kinds": [ 1 ], "limit": 1 },
{ "authors": [ "e" ], "kinds": [ 1 ], "limit": 1 },
{ "authors": [ "f" ], "kinds": [ 1 ], "limit": 1 },
{ "authors": [ "g" ], "kinds": [ 1 ], "limit": 1 },
{ "authors": [ "h" ], "kinds": [ 1 ], "limit": 1 },
{ "authors": [ "i" ], "kinds": [ 1 ], "limit": 1 }
...
* 1000
]
|
YES!!! |
|
Lol vitor i knew you would like this one. Please don't DoS me. |
hoytech
approved these changes
Dec 20, 2024
|
yeah 20 seems a bit small, especially if we want to do these kinds of queries, up to you! |
|
20 -> 1000 :) |
jb55
added a commit
to damus-io/notedeck
that referenced
this pull request
Dec 27, 2024
This function creates filters for the base our first algo in Damus:
Called "last N note per pubkey". I don't have a better name for it.
This function generates a query in the form:
[
{"authors": ["author_a"], "limit": 1, "kinds": [1]
, {"authors": ["author_b"], "limit": 1, "kinds": [1]
, {"authors": ["author_c"], "limit": 1, "kinds": [1]
, {"authors": ["author_c"], "limit": 1, "kinds": [1]
...
]
Due to an unfortunate restriction currently in nostrdb and strfry, we
can only do about 16 to 20 of these at any given time. I have made
this limit configurable in strfry[1]. I just need to do the same in
nostrdb now.
[1] hoytech/strfry#133
Changelog-Added: Add last_n_per_pubkey_from_tags algo function
jb55
added a commit
to damus-io/notedeck
that referenced
this pull request
Jan 14, 2025
This function creates filters for the base our first algo in Damus:
Called "last N note per pubkey". I don't have a better name for it.
This function generates a query in the form:
[
{"authors": ["author_a"], "limit": 1, "kinds": [1]
, {"authors": ["author_b"], "limit": 1, "kinds": [1]
, {"authors": ["author_c"], "limit": 1, "kinds": [1]
, {"authors": ["author_c"], "limit": 1, "kinds": [1]
...
]
Due to an unfortunate restriction currently in nostrdb and strfry, we
can only do about 16 to 20 of these at any given time. I have made
this limit configurable in strfry[1]. I just need to do the same in
nostrdb now.
[1] hoytech/strfry#133
Changelog-Added: Add last_n_per_pubkey_from_tags algo function
jb55
added a commit
to damus-io/notedeck
that referenced
this pull request
Jan 20, 2025
This function creates filters for the base our first algo in Damus:
Called "last N note per pubkey". I don't have a better name for it.
This function generates a query in the form:
[
{"authors": ["author_a"], "limit": 1, "kinds": [1]
, {"authors": ["author_b"], "limit": 1, "kinds": [1]
, {"authors": ["author_c"], "limit": 1, "kinds": [1]
, {"authors": ["author_c"], "limit": 1, "kinds": [1]
...
]
Due to an unfortunate restriction currently in nostrdb and strfry, we
can only do about 16 to 20 of these at any given time. I have made
this limit configurable in strfry[1]. I just need to do the same in
nostrdb now.
[1] hoytech/strfry#133
Changelog-Added: Add last_n_per_pubkey_from_tags algo function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configurable option for expanding the number of allowed filters in REQ.
The motivation here is to support queries of this nature: