Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always have a error when save #1

Open
Einstein8 opened this issue Feb 26, 2021 · 10 comments · May be fixed by #5
Open

Always have a error when save #1

Einstein8 opened this issue Feb 26, 2021 · 10 comments · May be fixed by #5

Comments

@Einstein8
Copy link

Einstein8 commented Feb 26, 2021

Load a save date and even do nothing,there is always a error "There is no property called 'intelligence’. Cannot add new properties" when I try to save it.

@hozuki
Copy link
Owner

hozuki commented Feb 28, 2021

Strange. The field intelligence is used for male characters (i.e. the player) and it should always be there disregarding save versions.

@zer0250
Copy link

zer0250 commented May 25, 2021

I succeeded to make it work when i commented out some related checks, but intelligence field left unedited. probably it is named incorrectly.

@quarterturn
Copy link

What's the fix for intelligence field? I have the same problem preventing me from writing a new save file.

Also I have some characters with 'feeling' and 'h degree' above 100 and this also presents a problem, though fixable by editing to be '100'.

@Malkovitz
Copy link

Still no fix. Broken editor.

@quarterturn
Copy link

quarterturn commented Jul 15, 2021

Still no fix. Broken editor.

Use the python based one. It works but doesn't translate to English. You can translate online with a screenshot. Some minor changes are needed due to library changes. I will submit a merge request back to that version or you can let me know if you want the details here.

Where you see msgpack.unpackdb in any of the files, encoding='ascii' needs to be replaced with raw=False, strict_map_key=False

@DawidKorach
Copy link

For me, commenting on the related check didn't help. @zer0250
I could save but the UI still was thinking that my character has 0 intelligence.
To fix my UI problem:

in KoikatuGameSaveEditor.Entities -> Entities -> MaleCharacter.cs
change:

public int Intelligence
{
	get => InternalCharacter.Intelligence ?? 0;
	set => InternalCharacter.Intelligence = value;
}

to

public int Intelligence
{
	get => InternalCharacter.Intelligence2 ?? 0;
	set => InternalCharacter.Intelligence2 = value;
}

Don't know how it works (due to @hozuki previous comment) or if it works in gameplay but the UI was fixed.

Splendide-Imaginarius added a commit to Splendide-Imaginarius/KoikatuGameSaveEditor that referenced this issue Dec 23, 2022
Fixes hozuki#1

Thanks DawidKorach for the tip.
@Splendide-Imaginarius Splendide-Imaginarius linked a pull request Dec 23, 2022 that will close this issue
@Splendide-Imaginarius
Copy link

@DawidKorach Thanks, I confirmed that your patch works (went in-game and the Intelligence stat was changed correctly). PR submitted.

@Death102
Copy link

Death102 commented Oct 5, 2023

so why is the code broken like it actually broke my game for a bit and i lost a lot of progress

@Death102
Copy link

Death102 commented Oct 5, 2023

also it does not even say intelligence anymore so it comes up as an error

@Splendide-Imaginarius
Copy link

so why is the code broken like it actually broke my game for a bit and i lost a lot of progress

@Death102 If you actually read the comment directly above yours, you would see that I already sent in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants